Add clippy to CI + address clippy problems #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
that referenced
this pull request
Apr 21, 2020
215: Add clippy to CI + address clippy problems r=kvark a=elrnv This commit 1. Adds `cargo clippy` to .travis.yml that is allowed to fail to reduce friction for incoming PRs. 2. Addresses clippy concerns and clarifies places where they should be ignored. Addresses half of #211 Co-authored-by: Egor Larionov <egor.larionov@gmail.com>
|
I think I had a |
|
Please rebase! |
This commit 1. adds `cargo clippy` to .travis.yml 2. addresses clippy concerns and clarifies places where they should be ignored.
The issue was that the from_str implementation on Value was moved to the FromStr trait as recommended by Clippy. This caused many of the tests to fail since now the FromStr trait must be in scope. Instead of bringing FromStr into scope everywhere, however, the `Value::from_str(_)` calls were replaced with `_.parse()` calls as recommended by the std lib documentation.
|
All done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit
cargo clippyto .travis.yml that is allowed to fail to reduce friction for incoming PRs.Addresses half of #211